New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using `overflow: scroll` anywhere #402

Closed
Diggsey opened this Issue Nov 29, 2018 · 5 comments

Comments

Projects
None yet
6 participants
@Diggsey
Copy link

Diggsey commented Nov 29, 2018

Design Feature Request

Summary

Please stop using overflow: scroll anywhere and use overflow: auto instead.

These are used at least on code boxes, but there's no reason to use overflow: scroll anywhere.

Motivation

overflow: scroll causes scrollbars to always appear on windows and linux, even when the content is not scrollable, which is just a waste of screen space and ugly given the colourful theme.

Drawbacks

None, unless someone prefers useless scrollbars to appear?

@enzozus

This comment has been minimized.

Copy link

enzozus commented Nov 29, 2018

The code boxes in most (all?) places don't have a maximum height set, and in those cases the vertical scrollbars (in Chrome) and the ugly weird scrolling corner (in Firefox) are completely unnecessary and can be removed by using overflow-x: scroll instead of overflow: scroll.

When there is a longer code example and you really want to restrict the height for the sake of layout it might be better to have an expander button to show all the code; this allows using the full height of the screen instead of scrolling around in a little box.

Also agree with using auto instead of scroll. This gets rid of even the horizontal scrollbar in many places. Carefully adjusting the code examples should get rid of all the scrollbars actually, but it's probably a good idea to keep overflow-x: auto around when the width is restricted.

@jay-aye-see-kay

This comment has been minimized.

Copy link
Contributor

jay-aye-see-kay commented Nov 30, 2018

I was going to raise basically the same issue, on desktops that aren't macOS overflow: scroll shows scroll bars all the time and they're a waste of space. As far as I can see the site only has this issue on code tags so could be fixed by changing https://github.com/rust-lang/beta.rust-lang.org/blob/d9ce21591dfaee3b431efca3df80701177339b00/src/styles/app.scss#L31 to overflow: auto;.

Really like the new site, awesome work

@meven

This comment has been minimized.

Copy link
Contributor

meven commented Dec 1, 2018

Under linux + firefox
currently : overflow: scroll
screenshot_20181201_181307
overflow : auto
screenshot_20181201_181330

@chriskrycho

This comment has been minimized.

Copy link
Contributor

chriskrycho commented Dec 1, 2018

I agree: that definitely doesn't look great! If one of you would like to open a PR, I'll merge it! Otherwise, I'll get to it either this afternoon or sometime over the next week.

@chriskrycho

This comment has been minimized.

Copy link
Contributor

chriskrycho commented Dec 2, 2018

Resolved in #522.

@chriskrycho chriskrycho closed this Dec 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment