Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upStop using `overflow: scroll` anywhere #402
Comments
ashleygwilliams
added
question
design
needs decision
and removed
question
labels
Nov 29, 2018
This comment has been minimized.
This comment has been minimized.
enzozus
commented
Nov 29, 2018
•
|
The code boxes in most (all?) places don't have a maximum height set, and in those cases the vertical scrollbars (in Chrome) and the ugly weird scrolling corner (in Firefox) are completely unnecessary and can be removed by using When there is a longer code example and you really want to restrict the height for the sake of layout it might be better to have an expander button to show all the code; this allows using the full height of the screen instead of scrolling around in a little box. Also agree with using |
This comment has been minimized.
This comment has been minimized.
|
I was going to raise basically the same issue, on desktops that aren't macOS Really like the new site, awesome work |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
I agree: that definitely doesn't look great! If one of you would like to open a PR, I'll merge it! Otherwise, I'll get to it either this afternoon or sometime over the next week. |
chriskrycho
self-assigned this
Dec 1, 2018
jay-aye-see-kay
referenced this issue
Dec 2, 2018
Merged
switch to overflow: scroll to auto on code tags #522
This comment has been minimized.
This comment has been minimized.
|
Resolved in #522. |


Diggsey commentedNov 29, 2018
Design Feature Request
Summary
Please stop using
overflow: scrollanywhere and useoverflow: autoinstead.These are used at least on code boxes, but there's no reason to use
overflow: scrollanywhere.Motivation
overflow: scrollcauses scrollbars to always appear on windows and linux, even when the content is not scrollable, which is just a waste of screen space and ugly given the colourful theme.Drawbacks
None, unless someone prefers useless scrollbars to appear?