Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign uptry to limit contrast in colors #478
Comments
This comment has been minimized.
This comment has been minimized.
lbolla
commented
Nov 30, 2018
|
There seem to be no semantic associated with colors either. E.g. blue is used in the second banner ("Build it in Rust"), but then the same color is used for buttons in the "Get involved" section. I find it confusing. |
This comment was marked as resolved.
This comment was marked as resolved.
|
We are not currently looking to overhaul the color or font scheme at this time. If you have small actionable tweaks you think we can make to improve this, I encourage you to file other issues. |
ashleygwilliams
closed this
Nov 30, 2018
This comment was marked as resolved.
This comment was marked as resolved.
|
@ashleygwilliams What is a small actionable tweak? I gave you two. If you don't consider these small actionable tweaks, you may as well say that the design is not up to debate and just close the issue tracker on this repository, as it is effectively useless. Anyway, looks like I was right to assume it would be closed non-sequitur. |
This comment was marked as resolved.
This comment was marked as resolved.
e-oz
commented
Dec 2, 2018
|
Hope you will excuse my tone as well, but you can use some browser addon/extension to customize CSS of sites you want. I understand black-and-white design is more readable, but really not all sites in the internet should be black and white. |
This comment was marked as resolved.
This comment was marked as resolved.
e-oz
commented
Dec 2, 2018
Is it really "beta"? |
This comment was marked as resolved.
This comment was marked as resolved.
|
@e-oz This is not about black-and-white design, just about increasing the contrast between (text, background) compared to the contrast between (background1, background2), for the part about the colors. @ashleygwilliams In case you assumed my point was about black-and-white, like @e-oz appears to have, could you consider reopening it? I really think the tweaks proposed here are minor and actionable, they're basically a minor color shift. If it's not, then I would love to hear what you consider minor and actionable style tweak, because I can't see anything more minor. |
This comment was marked as resolved.
This comment was marked as resolved.
|
hi @Ekleog ! i had thought so- but i will reopen to discuss just tweaks to some of the colors (bump them slightly darker or light)! sorry about that :) |
ashleygwilliams
reopened this
Dec 2, 2018
This comment was marked as resolved.
This comment was marked as resolved.
|
@e-oz yes this is a beta- which means we already went through an alpha (all members of any rust team or working group). in the beta we are looking to polish, not do major overhauls. let me know if i can clarify further. |
This comment was marked as resolved.
This comment was marked as resolved.
e-oz
commented
Dec 2, 2018
•
|
I got it from the first time, no need to be aggresive. |
ashleygwilliams
changed the title
Tone down colors and reduce title text size / font impact compared to content text size
Tone down colors
Dec 3, 2018
This comment has been minimized.
This comment has been minimized.
|
renaming this issue as #524 covers the text size in a bit more detail |
ashleygwilliams
changed the title
Tone down colors
try to limit contrast in colors
Dec 3, 2018
ashleygwilliams
added
the
design
label
Dec 3, 2018
ashleygwilliams
added this to the end-of-year milestone
Dec 3, 2018
ashleygwilliams
self-assigned this
Dec 3, 2018
This comment has been minimized.
This comment has been minimized.
dogweather
commented
Dec 5, 2018
|
This comment has been minimized.
This comment has been minimized.
CAD97
commented
Dec 5, 2018
Minor tweak proposal: align the backstroke such that it lines up with the low upper bound of the letters, rather than being just below it. (I don't know the font setting term, but such that only the risers are off the stroke rather than every character going above it.) This aligns the background line with one that already visually exists -- the top of non-riser characters -- but keeps the distinctive style. All in all, I like the new design, and realize that taking ideas from the community pushes into "design by committee" rather than the designer who actually designed the site, but this feels like an actionable suggestion that could work to mitigate that concern. |
This comment has been minimized.
This comment has been minimized.
I may be misunderstanding, but my impression of your suggestion is to create a tangent between the background and the text. This would decrease legibility in my opinion. I would suggest either not having lower case break the bounds of the background at all or lowering the background height further to create more distance between the lines of sight. The colors and levels of contrast are a bigger issue with regards to legibility, though. |
This comment has been minimized.
This comment has been minimized.
eddyp
commented
Dec 6, 2018
•
Before reading anything, please keep in mind that I have exactly 0 intention to offend anyone who got involved in the this valuable work, or dismiss their effort. I am a newbie in Rust, I appreciate the language and all the people involved in making the community and the language a success, so what I am saying comes from a place of best intentions and with the hope it will help make Edition 2018 the huge success story Rust deserves. After having a "elevator pitch" of Rust with some work colleagues and I sent them a link to https://www.rust-lang.org and to the Rustlings exercises and I hope they will take a look. OTOH, today I found out there is a beta.rust-lang.org, which I assume is planned to be the new language page to go hand in hand with the "2018 edition" launch. I took a look and have to confess I was immediately worried that with the beta design the chance my colleagues would try to Rust will be significantly lower. Please, do not take personally and do not consider this as an attack, but I really think you should take this one small actionable item:
If you will, you can consider interpreting the headline request to "limit the contrast in colors" by reducing the number of colors between which contrasts can occur. |
This comment has been minimized.
This comment has been minimized.
eddyp
commented
Dec 6, 2018
•
Looking at the current page, I think eliminating the yellow is easiest:
|
Ekleog commentedNov 30, 2018
Design Feature Request
(sorry for both the tone of this issue and for not following the template, the reaction at #468 (comment) makes me want to not spend a minute more than strictly needed to convey information, given I'm going under the assumption it'll be closed non-sequitur)
Rant about the current site and my inability to actually read the text in a reasonable amount of time is available at #468 (comment).
Issue: The text is so small and un-contrasted that reading it is hard.
Ideas:
Overall, the proposal in #468 is, to me, much more readable.