New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URLs for the old website should redirect (if appropriate) #593

Open
SimonSapin opened this Issue Dec 7, 2018 · 13 comments

Comments

Projects
None yet
8 participants
@SimonSapin

SimonSapin commented Dec 7, 2018

For example, https://www.rust-lang.org/conduct.html to https://www.rust-lang.org/policies/code-of-conduct instead of 404. Let’s try not to break existing links :)

@ashleygwilliams ashleygwilliams added the dev label Dec 7, 2018

@ashleygwilliams ashleygwilliams self-assigned this Dec 7, 2018

@ashleygwilliams ashleygwilliams added this to the end-of-year milestone Dec 7, 2018

@ashleygwilliams

This comment has been minimized.

Member

ashleygwilliams commented Dec 7, 2018

@SimonSapin if you have particular pages in mind (in addition to what you have already mentioned) please feel free to mention them here. I will make a PR soon to show the pattern for doing this and will welcome PRs to fill out the rest!

@SamWhited

This comment has been minimized.

SamWhited commented Dec 7, 2018

https://blog.rust-lang.org/feed.xml is also 404ing right now and my feed reader is broken.

@mbrubeck

This comment has been minimized.

Contributor

mbrubeck commented Dec 7, 2018

https://blog.rust-lang.org/feed.xml is also 404ing right now and my feed reader is broken.

This is rust-lang/blog.rust-lang.org#307.

@SimonSapin

This comment has been minimized.

SimonSapin commented Dec 7, 2018

I don’t have a specific URL in mind. But ideally, all of them. I think listing .md files in https://github.com/rust-lang/prev.rust-lang.org would provide an exhaustive list?

@mbrubeck

This comment has been minimized.

Contributor

mbrubeck commented Dec 7, 2018

#597 has redirects for all of the .md files in the old site except for faq.md, for which there is no reasonable equivalent in the new site.

@pickfire

This comment has been minimized.

Contributor

pickfire commented Dec 7, 2018

I think https://www.rust-lang.org/what/cli have some URLs that is redirecting to the 2018 edition book which is no longer distributed.

@mbrubeck

This comment has been minimized.

Contributor

mbrubeck commented Dec 7, 2018

I think https://www.rust-lang.org/what/cli have some URLs that is redirecting to the 2018 edition book which is no longer distributed.

These were fixed in b928a99.

Please file separate issues for other broken links that don't involve old www.rust-lang.org URIs.

@Aloso

This comment has been minimized.

Contributor

Aloso commented Dec 7, 2018

I guess, the most important redirects are

Because these links often appear in search results.

It would also be a good idea to go to Google's and Bing's webmaster tools, submit a sitemap and make sure that all pages are indexed again.

@RalfJung

This comment has been minimized.

Member

RalfJung commented Dec 19, 2018

Can we get this reopened? All the URLs mentioned here still yield 404.

Another one that went MIA is https://www.rust-lang.org/security.html.

@yoshuawuyts yoshuawuyts reopened this Dec 19, 2018

@mbrubeck

This comment has been minimized.

Contributor

mbrubeck commented Dec 19, 2018

Another one that went MIA is https://www.rust-lang.org/security.html.

This is fixed by #597 along with all the others (except "faq.html" which has no equivalent in the new site). The fix is merged but not yet deployed.

@SimonSapin

This comment has been minimized.

SimonSapin commented Dec 20, 2018

#597 is merged. Maybe it’s not deployed to production yet? How is deployment managed?

@Aloso

This comment has been minimized.

Contributor

Aloso commented Dec 22, 2018

It works now.

@RalfJung

This comment has been minimized.

Member

RalfJung commented Dec 22, 2018

Awesome. :) The issue can be closed then,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment