Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upURLs for the old website should redirect (if appropriate) #593
Comments
ashleygwilliams
added
the
dev
label
Dec 7, 2018
ashleygwilliams
self-assigned this
Dec 7, 2018
ashleygwilliams
added this to the end-of-year milestone
Dec 7, 2018
This comment has been minimized.
This comment has been minimized.
|
@SimonSapin if you have particular pages in mind (in addition to what you have already mentioned) please feel free to mention them here. I will make a PR soon to show the pattern for doing this and will welcome PRs to fill out the rest! |
This comment has been minimized.
This comment has been minimized.
SamWhited
commented
Dec 7, 2018
|
https://blog.rust-lang.org/feed.xml is also 404ing right now and my feed reader is broken. |
This comment has been minimized.
This comment has been minimized.
This is rust-lang/blog.rust-lang.org#307. |
This comment has been minimized.
This comment has been minimized.
SimonSapin
commented
Dec 7, 2018
|
I don’t have a specific URL in mind. But ideally, all of them. I think listing |
This comment has been minimized.
This comment has been minimized.
|
#597 has redirects for all of the .md files in the old site except for faq.md, for which there is no reasonable equivalent in the new site. |
This comment has been minimized.
This comment has been minimized.
|
I think https://www.rust-lang.org/what/cli have some URLs that is redirecting to the 2018 edition book which is no longer distributed. |
This comment has been minimized.
This comment has been minimized.
These were fixed in b928a99. Please file separate issues for other broken links that don't involve old www.rust-lang.org URIs. |
This comment has been minimized.
This comment has been minimized.
|
I guess, the most important redirects are
Because these links often appear in search results. It would also be a good idea to go to Google's and Bing's webmaster tools, submit a sitemap and make sure that all pages are indexed again. |
ozkriff
referenced this issue
Dec 10, 2018
Merged
htmlproofer: Ignore rustlang.org deadlinks for now #309
ashleygwilliams
closed this
in
#597
Dec 11, 2018
This comment has been minimized.
This comment has been minimized.
|
Can we get this reopened? All the URLs mentioned here still yield 404. Another one that went MIA is https://www.rust-lang.org/security.html. |
yoshuawuyts
reopened this
Dec 19, 2018
This comment has been minimized.
This comment has been minimized.
This is fixed by #597 along with all the others (except "faq.html" which has no equivalent in the new site). The fix is merged but not yet deployed. |
This comment has been minimized.
This comment has been minimized.
SimonSapin
commented
Dec 20, 2018
|
#597 is merged. Maybe it’s not deployed to production yet? How is deployment managed? |
This comment has been minimized.
This comment has been minimized.
|
It works now. |
This comment has been minimized.
This comment has been minimized.
|
Awesome. :) The issue can be closed then, |
SimonSapin commentedDec 7, 2018
For example, https://www.rust-lang.org/conduct.html to https://www.rust-lang.org/policies/code-of-conduct instead of 404. Let’s try not to break existing links :)