Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd redirects to keep old URIs working #597
Conversation
pietroalbini
reviewed
Dec 7, 2018
src/main.rs Outdated
mbrubeck
force-pushed the
mbrubeck:redirect
branch
2 times, most recently
from
abcd658
to
653d8fa
Dec 7, 2018
mbrubeck
referenced this pull request
Dec 7, 2018
Closed
URLs for the old website should redirect (if appropriate) #593
mbrubeck
force-pushed the
mbrubeck:redirect
branch
2 times, most recently
from
7968b28
to
6dbec50
Dec 7, 2018
This comment was marked as off-topic.
This comment was marked as off-topic.
Soria0906
commented
Dec 7, 2018
|
Ok |
ashleygwilliams
self-requested a review
Dec 7, 2018
ashleygwilliams
added
the
needs review
label
Dec 7, 2018
added a commit
to ehuss/cargo
that referenced
this pull request
Dec 9, 2018
This comment has been minimized.
This comment has been minimized.
Carreau
commented
Dec 9, 2018
|
Do you want to log the referrer if possible when redirect, so that some could get fixed (like stackoverflow)? |
added a commit
to rust-lang/cargo
that referenced
this pull request
Dec 9, 2018
VladimirMarkelov
reviewed
Dec 10, 2018
src/redirect.rs Outdated
mbrubeck
force-pushed the
mbrubeck:redirect
branch
from
6dbec50
to
bd73c00
Dec 10, 2018
Dmitry-Borodin
reviewed
Dec 10, 2018
| "https://forge.rust-lang.org/other-installation-methods.html" | ||
| } | ||
| "security.html" => "/policies/security", | ||
| "team.html" => "/governance", |
This comment has been minimized.
This comment has been minimized.
Dmitry-Borodin
Dec 10, 2018
•
currently both
https://www.rust-lang.org/en-US/team.html (current version in appendix-07)
https://www.rust-lang.org/en-US/governance
does not work
What should be used in the book?
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Travis failure is known Rustfmt/Rustup issue |
Dmitry-Borodin
referenced this pull request
Dec 11, 2018
Closed
Update links according to the new website #1678
ashleygwilliams
merged commit 00be98d
into
rust-lang:master
Dec 11, 2018
1 check failed
continuous-integration/travis-ci/pr
The Travis CI build failed
Details
This comment has been minimized.
This comment has been minimized.
|
Did this get deployed yet? The links at #593 (comment) are still broken. |
This comment has been minimized.
This comment has been minimized.
|
it is not deployed yet- i am backed up on reviews and need to get the rocket fix one in. it should be today. sorry about that! |
skade
referenced this pull request
Dec 13, 2018
Closed
Old rust install link should redirect to the new one #640
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
mbrubeck commentedDec 7, 2018
•
edited
This will allow existing links to the Rust code of conduct and other pages to keep working, instead of returning 404 errors. Fixes #593 .