Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to the edition guide from the "learn" page #697

Merged
merged 1 commit into from Jan 31, 2019

Conversation

Projects
None yet
2 participants
@siddharthasahu
Copy link
Contributor

siddharthasahu commented Jan 29, 2019

@yoshuawuyts
Copy link
Member

yoshuawuyts left a comment

This looks excellent. Thank you!

@yoshuawuyts

This comment has been minimized.

Copy link
Member

yoshuawuyts commented Jan 31, 2019

Rendered:

2019-01-31-013149_1920x1080

@yoshuawuyts yoshuawuyts merged commit 9a9f1cf into rust-lang:master Jan 31, 2019

@siddharthasahu

This comment has been minimized.

Copy link
Contributor Author

siddharthasahu commented Jan 31, 2019

Thank you @yoshuawuyts.

After seeing the render, do you think the text should be expanded somehow (e.g., A guide that describes the Rust editions.) to match the length of the other texts?

@siddharthasahu siddharthasahu deleted the siddharthasahu:patch-1 branch Jan 31, 2019

@yoshuawuyts

This comment has been minimized.

Copy link
Member

yoshuawuyts commented Jan 31, 2019

Do you think the text should be expanded somehow?

Perhaps! -- if you have any ideas to improve the flow of content, go for it! -- we can always workshop the details in an issue / PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.