Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd link to the edition guide from the "learn" page #697
Conversation
yoshuawuyts
approved these changes
Jan 31, 2019
|
This looks excellent. Thank you! |
This comment has been minimized.
This comment has been minimized.
yoshuawuyts
merged commit 9a9f1cf
into
rust-lang:master
Jan 31, 2019
This comment has been minimized.
This comment has been minimized.
|
Thank you @yoshuawuyts. After seeing the render, do you think the text should be expanded somehow (e.g., A guide that describes the Rust editions.) to match the length of the other texts? |
siddharthasahu
deleted the
siddharthasahu:patch-1
branch
Jan 31, 2019
This comment has been minimized.
This comment has been minimized.
Perhaps! -- if you have any ideas to improve the flow of content, go for it! -- we can always workshop the details in an issue / PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.

siddharthasahu commentedJan 29, 2019
From the discussion at https://internals.rust-lang.org/t/no-love-for-the-edition-guide/9308/2