Added HTTP error output to provide visible feedback to the user #53
Conversation
saschagrunert
left a comment
saschagrunert
left a comment
There was a problem hiding this comment.
Thank you very much for contributing. What do you think of my proposals?
| match status { | ||
| status::NotFound => | ||
| (ContentType::html().0, status, " | ||
| <html> |
There was a problem hiding this comment.
Okay since we want to have it hard coded what about the usage of include_str!?
|
|
||
| if !path.exists() { | ||
| return Ok(Response::with(status::InternalServerError)); | ||
| return Ok(Response::with(get_http_error_as_html(status::NotFound))); |
There was a problem hiding this comment.
To avoid the function(in_function(in_function(...))) calls we ca add a new Trait to iron::status::Status which returns our HTML in case on an error.
|
For the Trait option i'm somewhat indifferent, i suppose it could be nicer if we don't have to add a whole bunch of other stuff around it for that to work. |
|
Alright then I propose to use the |
4 participants
This adds some visible output on 404 and 500 errors using internal pre-defined html.
These internal strings are fine as a fallback but later on there should be themed and customizable versions of these. But for this we first need to think of a template engine and the overall directory structure (where should those error pages be located?).
I used a function for this to avoid stuffing the strings into the HTTP handling. Albeit this probably isn't the prettiest solution yet.
This is for issue #51