Fix build warnings on Rust 1.37+ #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `mem::uninitialized()` function is considered undefined behavior, and is therefore heavily deprecated. Instead, `mem::MaybeUninit` is preferred. Convert the usage of `mem::uninitialized()` into `mem::MaybeUninit` in the `Transform::identity()` function to remove this UB. Signed-off-by: Sean Cross <sean@xobs.io>
The constant ATOMIC_BOOL_INIT was deprecated when const fn support was added, because `AtomicBool::new()` can now be used. Replace this constant with the function call in order to remove a deprecated warning. Signed-off-by: Sean Cross <sean@xobs.io>
As of Rust 1.37, trait objects without the `dyn` marker will produce warnings. This results in many warnings when building `iui`. Annotate all trait objects with this dyn marker. Signed-off-by: Sean Cross <sean@xobs.io>
NoraCodes
added
k-buildprocess
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patchset fixes build warnings that were encountered when using Rust 1.42.0. These most likely exist on any Rust version since 1.37.
Note that this bumps the MSRV up to at least 1.36, since that's when
mem::MaybeUninitwas introduced.