From a78f9900e51960d8cd1a8f02ad9e5be3e0d65ecf Mon Sep 17 00:00:00 2001
From: Ulrik Sverdrup <bluss@users.noreply.github.com>
Date: Wed, 21 Aug 2024 17:36:56 +0200
Subject: [PATCH] Fix uniqueness in last_mut()

Last mut did not ensure the array was unique before calling uget_mut.
The required properties were protected by a debug assertion, but a clear
bug in release mode.

Adding tests that would have caught this.
---
 src/impl_methods.rs | 43 +++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 43 insertions(+)

diff --git a/src/impl_methods.rs b/src/impl_methods.rs
index 589a5c83c..f506204b6 100644
--- a/src/impl_methods.rs
+++ b/src/impl_methods.rs
@@ -406,6 +406,7 @@ where
         if self.is_empty() {
             None
         } else {
+            self.ensure_unique();
             let mut index = self.raw_dim();
             for ax in 0..index.ndim() {
                 index[ax] -= 1;
@@ -3081,6 +3082,7 @@ mod tests
 {
     use super::*;
     use crate::arr3;
+    use defmac::defmac;
 
     #[test]
     fn test_flatten()
@@ -3107,4 +3109,45 @@ mod tests
         let flattened = array.into_flat();
         assert_eq!(flattened, arr1(&[1, 2, 3, 4, 5, 6, 7, 8]));
     }
+
+    #[test]
+    fn test_first_last()
+    {
+        let first = 2;
+        let last = 3;
+
+        defmac!(assert_first mut array => {
+            assert_eq!(array.first().copied(), Some(first));
+            assert_eq!(array.first_mut().copied(), Some(first));
+        });
+        defmac!(assert_last mut array => {
+            assert_eq!(array.last().copied(), Some(last));
+            assert_eq!(array.last_mut().copied(), Some(last));
+        });
+
+        let base = Array::from_vec(vec![first, last]);
+        let a = base.clone();
+        assert_first!(a);
+
+        let a = base.clone();
+        assert_last!(a);
+
+        let a = CowArray::from(base.view());
+        assert_first!(a);
+        let a = CowArray::from(base.view());
+        assert_last!(a);
+
+        let a = CowArray::from(base.clone());
+        assert_first!(a);
+        let a = CowArray::from(base.clone());
+        assert_last!(a);
+
+        let a = ArcArray::from(base.clone());
+        let _a2 = a.clone();
+        assert_last!(a);
+
+        let a = ArcArray::from(base.clone());
+        let _a2 = a.clone();
+        assert_first!(a);
+    }
 }