Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make stack and concatenate compliant with numpy naming. #850

merged 2 commits into from Nov 28, 2020


Copy link

This PR changes the naming used for stack/concatenate to be compliant with the one from numpy. In particular:

  • stack function and macro are now aliases to stack_new_axis. They join the arrays along a new axis.
  • the implementation of former stack function is now moved to the concatenate function. It is used to join the arrays along the existing axis.
  • stack function and macro are no longer deprecated.

This change is not backward-compatible and should be released within 0.14.

@andrei-papou andrei-papou changed the title Renamed stack and concatenate to be compliant with numpy naming. Make stack and concatenate compliant with numpy naming. Nov 24, 2020
Copy link

bluss commented Nov 28, 2020

Thanks, let's go for this in 0.14

@bluss bluss merged commit 716221c into rust-ndarray:master Nov 28, 2020
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants