Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a few inconsistencies around negative strides in constructors #948

merged 2 commits into from Mar 23, 2021


Copy link

@bluss bluss commented Mar 22, 2021

The ArrayView from_shape constructors that allow and have a natural interpretation for the array head pointer, now support negative strides properly.

Note that the raw view and raw pointer constructors for regular views don't support negative strides yet. There are assertions to check this. The goal of this PR is to have consistency for the next release, not to add new features for negative strides.

The first commit is by @SparrowLii (some changes dropped from that commit) from PR #901.

Closes #942

@bluss bluss changed the title Neg stride constructors Fix a few inconsistencies around negative strides in constructors Mar 22, 2021
@bluss bluss merged commit fdbc884 into master Mar 23, 2021
7 checks passed
@bluss bluss deleted the neg-stride-constructors branch March 23, 2021 20:20
@bluss bluss added this to the 0.15.0 milestone Mar 23, 2021
Copy link
Member Author

bluss commented Mar 23, 2021

This is sort of a follow-up to #885

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

Fix inconsistencies around negative strides in constructors
2 participants