New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LowerHex and UpperHex formatting #158

Merged
merged 4 commits into from Jan 18, 2016

Conversation

Projects
None yet
3 participants
@AnchoviesHat
Contributor

AnchoviesHat commented Jan 17, 2016

These were mysteriously missing from BigUint.

@AnchoviesHat

This comment has been minimized.

Show comment
Hide comment
@AnchoviesHat

AnchoviesHat Jan 17, 2016

Contributor

Collections were not stabilized in 1.0.0, causing the build failure. As an alternative, I could pull in std::ascii::AsciiExt, and use its uppercase function.

Contributor

AnchoviesHat commented Jan 17, 2016

Collections were not stabilized in 1.0.0, causing the build failure. As an alternative, I could pull in std::ascii::AsciiExt, and use its uppercase function.

@cuviper

This comment has been minimized.

Show comment
Hide comment
@cuviper

cuviper Jan 17, 2016

Member
Member

cuviper commented Jan 17, 2016

@AnchoviesHat

This comment has been minimized.

Show comment
Hide comment
@AnchoviesHat

AnchoviesHat Jan 17, 2016

Contributor

What is the best way to test this? Verify that the resulting string is the same as what from_str_radix would have returned? I could check that UpperHex and LowerHex return the same value?

Contributor

AnchoviesHat commented Jan 17, 2016

What is the best way to test this? Verify that the resulting string is the same as what from_str_radix would have returned? I could check that UpperHex and LowerHex return the same value?

@cuviper

This comment has been minimized.

Show comment
Hide comment
@cuviper

cuviper Jan 17, 2016

Member
Member

cuviper commented Jan 17, 2016

AnchoviesHat added some commits Jan 17, 2016

Fix test names
Upper and Lower test names were swapped
@cuviper

This comment has been minimized.

Show comment
Hide comment
@cuviper

cuviper Jan 18, 2016

Member

Great, thanks!

@homu r+ a89a2e8

Member

cuviper commented Jan 18, 2016

Great, thanks!

@homu r+ a89a2e8

@homu

This comment has been minimized.

Show comment
Hide comment
@homu

homu Jan 18, 2016

Contributor

⚡️ Test exempted - status

Contributor

homu commented Jan 18, 2016

⚡️ Test exempted - status

@homu homu merged commit a89a2e8 into rust-num:master Jan 18, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test exempted
Details

homu added a commit that referenced this pull request Jan 18, 2016

Auto merge of #158 - anchovieshat:master, r=cuviper
Add LowerHex and UpperHex formatting

These were mysteriously missing from BigUint.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment