Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test to make sure AmlContext remains Send + Sync #98

Closed
IsaacWoods opened this issue Jun 1, 2021 · 0 comments · Fixed by #100
Closed

Add test to make sure AmlContext remains Send + Sync #98

IsaacWoods opened this issue Jun 1, 2021 · 0 comments · Fixed by #100
Labels

Comments

@IsaacWoods
Copy link
Member

When we introduced native methods, AmlContext lost its Send + Sync, as methods weren't constrained to be thread-safe. This was fixed in #91 by requiring them to be, but it's unfortunate that this wasn't picked up before then (and so we have broken releases, which is fine per our semver commitments, but not great).

A test that makes sure that AmlContext is Send + Sync should be pretty easy and will trip CI if we make a change that breaks this in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant