From 28e015084da6f8580b4bba5b9f46e2f87ddfd191 Mon Sep 17 00:00:00 2001
From: Zavier Divelbiss <semiviral@gmail.com>
Date: Thu, 18 Aug 2022 15:06:13 -0500
Subject: [PATCH 1/2] fix `PM_TMR_BLK` parsing logic, comments

---
 acpi/src/fadt.rs | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/acpi/src/fadt.rs b/acpi/src/fadt.rs
index e61dcacd..34916915 100644
--- a/acpi/src/fadt.rs
+++ b/acpi/src/fadt.rs
@@ -256,7 +256,14 @@ impl Fadt {
         }
     }
 
+    /// Attempts to parse the FADT's PWM timer blocks, first returning the extended block, and falling back to
+    /// parsing the legacy block into a `GenericAddress`.
     pub fn pm_timer_block(&self) -> Result<Option<GenericAddress>, AcpiError> {
+        // ACPI spec indicates `PM_TMR_LEN` should be 4, or otherwise the PM_TMR is not supported.
+        if self.pm_timer_length != 4 {
+            return Ok(None);
+        }
+
         if let Some(raw) = unsafe { self.x_pm_timer_block.access(self.header().revision) } {
             if raw.address != 0x0 {
                 return Ok(Some(GenericAddress::from_raw(raw)?));
@@ -266,7 +273,7 @@ impl Fadt {
         if self.pm_timer_block != 0 {
             Ok(Some(GenericAddress {
                 address_space: AddressSpace::SystemIo,
-                bit_width: self.pm_timer_length * 8,
+                bit_width: 32,
                 bit_offset: 0,
                 access_size: AccessSize::Undefined,
                 address: self.pm_timer_block.into(),

From 5f04c4c962a40df05369d4385a1258df6ea0a22f Mon Sep 17 00:00:00 2001
From: Zavier Divelbiss <semiviral@gmail.com>
Date: Thu, 18 Aug 2022 15:06:45 -0500
Subject: [PATCH 2/2] comments, eq & copy on INT enum types

---
 acpi/src/platform/interrupt.rs | 21 +++++++++++++++++----
 aml/src/lib.rs                 |  3 ++-
 2 files changed, 19 insertions(+), 5 deletions(-)

diff --git a/acpi/src/platform/interrupt.rs b/acpi/src/platform/interrupt.rs
index fc034385..c2569423 100644
--- a/acpi/src/platform/interrupt.rs
+++ b/acpi/src/platform/interrupt.rs
@@ -15,26 +15,39 @@ pub struct NmiLine {
     pub line: LocalInterruptLine,
 }
 
-#[derive(Debug)]
+/// Indicates which local interrupt line will be utilized by an external interrupt. Specifically,
+/// these lines directly correspond to their requisite LVT entries in a processor's APIC.
+#[derive(Debug, Clone, Copy, PartialEq, Eq)]
 pub enum LocalInterruptLine {
     Lint0,
     Lint1,
 }
 
-#[derive(Debug)]
+#[derive(Debug, Clone, Copy, PartialEq, Eq)]
 pub enum NmiProcessor {
     All,
     ProcessorUid(u32),
 }
 
-#[derive(Debug)]
+/// Polarity indicates what signal mode the interrupt line needs to be in to be considered 'active'.
+#[derive(Debug, Clone, Copy, PartialEq, Eq)]
 pub enum Polarity {
     SameAsBus,
     ActiveHigh,
     ActiveLow,
 }
 
-#[derive(Debug)]
+/// Trigger mode of an interrupt, describing how the interrupt is triggered.
+///
+/// When an interrupt is `Edge` triggered, it is triggered exactly once, when the interrupt
+/// signal goes from its opposite polarity to its active polarity.
+///
+/// For `Level` triggered interrupts, a continuous signal is emitted so long as the interrupt
+/// is in its active polarity.
+///
+/// `SameAsBus`-triggered interrupts will utilize the same interrupt triggering as the system bus
+/// they communicate across.
+#[derive(Debug, Clone, Copy, PartialEq, Eq)]
 pub enum TriggerMode {
     SameAsBus,
     Edge,
diff --git a/aml/src/lib.rs b/aml/src/lib.rs
index 64967505..188739c2 100644
--- a/aml/src/lib.rs
+++ b/aml/src/lib.rs
@@ -661,7 +661,7 @@ impl AmlContext {
     }
 }
 
-// TODO: docs
+/// Trait type used by [`AmlContext`] to handle reading and writing to various types of memory in the system.
 pub trait Handler: Send + Sync {
     fn read_u8(&self, address: usize) -> u8;
     fn read_u16(&self, address: usize) -> u16;
@@ -694,6 +694,7 @@ pub trait Handler: Send + Sync {
     }
 }
 
+/// Used when an [`AmlContext`] encounters an error.
 #[derive(Clone, PartialEq, Eq, Debug)]
 pub enum AmlError {
     /*