Add Multiprocessor Wakeup structure #99
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IsaacWoods
requested changes
Jun 4, 2021
acpi/src/madt.rs
Outdated
| @@ -86,6 +86,10 @@ impl Madt { | |||
| MadtEntry::GicInterruptTranslationService(_) => { | |||
| unimplemented!(); | |||
| } | |||
|
|
|||
| MadtEntry::MultiprocessorWakeup(_) => { | |||
There was a problem hiding this comment.
This isn't quite right - we don't want to panic if we encounter one of these. It's probably safest to do nothing in this case, as the MADT should always contain other types of entries (i.e. MadtEntry::MultiprocessorWakeup(_) => (),
IsaacWoods
approved these changes
Jun 5, 2021
There was a problem hiding this comment.
Great - thanks! This will allow users parsing the MADT themselves to access this structure, which is a good start - in the future we can expose the mailbox, if detected, via the Platform abstraction, hopefully presenting a nice interface such as fn bringup_processor(processor: &Processor, address: u64).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #87