-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite: Remove support for bootimage {run, test}
#55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We only support running/testing through the runner executable from now on.
Set a default target in a `.cargo/config` file instead.
…rn non-zero exit code
Move kernel package location code into a new public function.
The `cargo bootimage` command only deals with binaries, so we don't need to try to derive the manifest path for test or doctest executables.
For doctests it's not possible to derive the manifest path from the executable path and the cargo metadata since doctests live under temp and all use the same name ('rust-out'). Fortunately, cargo sets a `CARGO_MANIFEST_DIR` environment variable for runner executables that points to the manifest path of the executable (which can be different from the root manifest path for workpace projects.)
Published as version 0.8.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request rewrites the
bootimage
crate almost completely. The most notable changes are:bootimage run
andbootimage test
commands because they were difficult to maintain.default-target
config key because it did not play nice with cargo workspaces.bootimage
as a library will need to update their code when updating to the new (semver-incompatible) API.Cargo.toml
file to makebootimage
work with cargo workspaces.anyhow
/thiserror
crates.Migration
Users of
bootimage run
should switch to the runner-based API provided by thebootimage runner
sucommand as described here. Instead ofbootimage test
, custom test frameworks should be used together withcargo xtest
. Instead of using thedefault-target
config key, setting a default target is possible through abuild.target
key in a.cargo/config
file.Fixes #54