Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable kernel stack size, better non-x86_64 errors #72

Merged
merged 2 commits into from Aug 5, 2019

Conversation

@64
Copy link
Contributor

commented Aug 2, 2019

Allows the configuration of the kernel stack size through an environment variable.

Also makes the errors a bit nicer if you try to use this crate from a non-x86_64 architecture (only works if you build it as a library), as discussed in #70.

@phil-opp

This comment has been minimized.

Copy link
Member

commented Aug 2, 2019

Looks good to me! Nice cleanup in the build.rs.

CI is currently broken because of rust-lang/rust#63195. Since this is a non-critical change I would probably wait a day or two until the issue is fixed instead of force-merging.

@phil-opp

This comment has been minimized.

Copy link
Member

commented Aug 5, 2019

I think the rust nightly should be fixed now.

bors r+

bors bot added a commit that referenced this pull request Aug 5, 2019
Merge #72
72: Configurable kernel stack size, better non-x86_64 errors r=phil-opp a=64

Allows the configuration of the kernel stack size through an environment variable.

Also makes the errors a bit nicer if you try to use this crate from a non-x86_64 architecture (only works if you build it as a library), as discussed in #70.

Co-authored-by: Matt Taylor <mstaveleytaylor@gmail.com>
@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 5, 2019

Build failed

  • rust-osdev.bootloader
@phil-opp

This comment has been minimized.

Copy link
Member

commented Aug 5, 2019

@64 Could you cargo fmt this?

@64

This comment has been minimized.

Copy link
Contributor Author

commented Aug 5, 2019

Damn, I really need to set up a pre-commit hook or something...

@64 64 force-pushed the 64:stack-size branch from 83729b9 to cc59140 Aug 5, 2019
Copy link
Member

left a comment

Thanks!

bors r+

bors bot added a commit that referenced this pull request Aug 5, 2019
Merge #72
72: Configurable kernel stack size, better non-x86_64 errors r=phil-opp a=64

Allows the configuration of the kernel stack size through an environment variable.

Also makes the errors a bit nicer if you try to use this crate from a non-x86_64 architecture (only works if you build it as a library), as discussed in #70.

Co-authored-by: Matt Taylor <mstaveleytaylor@gmail.com>
@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 5, 2019

Build succeeded

  • rust-osdev.bootloader
@bors bors bot merged commit cc59140 into rust-osdev:master Aug 5, 2019
5 checks passed
5 checks passed
bors Build succeeded
Details
rust-osdev.bootloader Build #20190805.3 succeeded
Details
rust-osdev.bootloader (Job linux) Job linux succeeded
Details
rust-osdev.bootloader (Job mac) Job mac succeeded
Details
rust-osdev.bootloader (Job windows) Job windows succeeded
Details
@64 64 deleted the 64:stack-size branch Aug 5, 2019
phil-opp added a commit that referenced this pull request Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.