Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add xdoc command #39

Merged
merged 1 commit into from Jul 9, 2019

Conversation

@Aehmlo
Copy link

commented Jul 8, 2019

By setting RUSTDOCFLAGS in addition to RUSTFLAGS, this patch allows rustdoc to inherit the modified sysroot. Closes #38.

(Figured I'd log RUSTDOCFLAGS in verbose mode too, in case future versions set it to something different than RUSTFLAGS, and since it's, well, verbose mode. Additionally, passing a reference to Command:env is totally equivalent to passing an owned string. Pretty minor patch.)

Add xdoc command.
Setting RUSTDOCFLAGS in addition to RUSTFLAGS causes rustdoc to use the
desired sysroot.

Closes #38.

@Aehmlo Aehmlo changed the title Add xdoc command. Add xdoc command Jul 8, 2019

@phil-opp

This comment has been minimized.

Copy link
Member

commented Jul 9, 2019

Looks good to me, thanks a lot!

@phil-opp phil-opp merged commit f7904f4 into rust-osdev:master Jul 9, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

phil-opp added a commit that referenced this pull request Jul 9, 2019

@phil-opp

This comment has been minimized.

Copy link
Member

commented Jul 9, 2019

Published as version 0.5.13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.