Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't append a `--sysroot` argument to `RUSTFLAGS` if it already contains one #40

Merged
merged 1 commit into from Jul 11, 2019

Conversation

@phil-opp
Copy link
Member

commented Jul 11, 2019

Appending the flag a second time leads to a "Option 'sysroot' given more than once" error.

This problem occurs because the user might set the RUSTFLAGS environment manually, for example for getting RLS to work.

@phil-opp phil-opp force-pushed the avoid-double-sysroot branch from 52038c6 to eb56ea1 Jul 11, 2019

@phil-opp phil-opp merged commit 8eab26a into master Jul 11, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@phil-opp phil-opp deleted the avoid-double-sysroot branch Jul 11, 2019

@phil-opp

This comment has been minimized.

Copy link
Member Author

commented Jul 11, 2019

Published as 0.5.14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.