Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `--quiet` flag that suppresses "waiting for file lock" message #43

Merged
merged 1 commit into from Dec 13, 2019

Conversation

@Nils-TUD
Copy link

Nils-TUD commented Sep 4, 2019

I think the "waiting for file lock" message shouldn't be printed unconditionally. In this PR, I've chosen to use the existing verbose flag to turn it on. An alternative would be to use a quiet flag, just as cargo does, to turn it off. I'm not sure what's better.

The reason I ran into this is that I'm using the ninja build system which updates a single line on the console to show the executing commands. That is, only errors create newlines and stay visible. Therefore, I'm passing "-q" to cargo, but unfortunately this get's ignored by cargo-xbuild.

Edit(phil-opp): We decided to add a --quiet flag instead of using the existing --verbose flag.

@phil-opp

This comment has been minimized.

Copy link
Member

phil-opp commented Sep 9, 2019

Thanks for the pull request and sorry for the late reply!

I think the "waiting for file lock" message can be quite useful. Without it, it is not clear why the command hangs. For this reason I would prefer to keep it enabled by default. So I think adding support for the quiet flag makes more sense than coupling it with the verbose flag.

@Nils-TUD Nils-TUD force-pushed the Nils-TUD:flock-verbose branch from cf9fb03 to 4cacb54 Sep 9, 2019
@Nils-TUD Nils-TUD force-pushed the Nils-TUD:flock-verbose branch from 4cacb54 to 6dcc9e9 Sep 17, 2019
@phil-opp

This comment has been minimized.

Copy link
Member

phil-opp commented Dec 2, 2019

@Nils-TUD Sorry for the late reply! I missed that you pushed new commits.

I'm not sure about the status of this. In 4cacb54 you changed the code to use a --quiet flag, but in the current 6dcc9e9 you switched it back to using the --verbose flag. Was this intended?

@Nils-TUD Nils-TUD force-pushed the Nils-TUD:flock-verbose branch from 6dcc9e9 to edfc143 Dec 6, 2019
@Nils-TUD

This comment has been minimized.

Copy link
Author

Nils-TUD commented Dec 6, 2019

No, that was not intended. Not sure what happened there.

But I've just pushed the old commit again.

@phil-opp phil-opp changed the title Print "waiting for file lock" message only in verbose mode Add `--quiet` flag that suppresses "waiting for file lock" message Dec 13, 2019
Copy link
Member

phil-opp left a comment

Looks good to me, thanks!

@phil-opp phil-opp merged commit b4c2736 into rust-osdev:master Dec 13, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@phil-opp

This comment has been minimized.

Copy link
Member

phil-opp commented Dec 13, 2019

Published as version 0.5.19

phil-opp added a commit that referenced this pull request Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.