Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print a warning when building for the host target #44

Merged
merged 1 commit into from Sep 10, 2019

Conversation

@phil-opp
Copy link
Member

commented Sep 10, 2019

Building for the host system target is often not intended.

It will also cause 'can't find crate for std' errors in build scripts of dependencies, which try to use the standard library. The reason is that cargo applies the RUSTFLAGS environment variable also to build scripts in native compilation mode, thereby overriding the sysroot.

This issue was reported in phil-opp/blog_os#403 (comment).

@phil-opp phil-opp merged commit d31f171 into master Sep 10, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@phil-opp phil-opp deleted the warning-host-target branch Sep 10, 2019
@phil-opp

This comment has been minimized.

Copy link
Member Author

commented Sep 10, 2019

Published as version 0.5.16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.