Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't print warning about missing root package in quiet mode. #79

Merged
merged 1 commit into from May 24, 2020

Conversation

Nils-TUD
Copy link

@Nils-TUD Nils-TUD commented May 24, 2020

There does not seem to be a way to avoid that warning if a workspace is used. So, allow the user to disable the warning by passing --quiet to cargo-xbuild.

There does not seem to be a way to avoid that warning if a workspace is
used. So, allow the user to disable the warning by passing --quiet to
cargo-xbuild.
@phil-opp
Copy link
Member

phil-opp commented May 24, 2020

Thanks for the PR!

One way to avoid the warning is to make the workspace root a package too, e.g. by creating an empty lib.rs and adding a package section to the root Cargo.toml. This way, cargo-xbuild can read its config from that root Cargo.toml.

I still agree that we shouldn't print the warning in quiet mode.

@phil-opp phil-opp merged commit be30398 into rust-osdev:master May 24, 2020
phil-opp added a commit that referenced this pull request May 24, 2020
@phil-opp
Copy link
Member

phil-opp commented May 24, 2020

Published as v0.5.33.

@Nils-TUD
Copy link
Author

Nils-TUD commented May 25, 2020

One way to avoid the warning is to make the workspace root a package too, e.g. by creating an empty lib.rs and adding a package section to the root Cargo.toml. This way, cargo-xbuild can read its config from that root Cargo.toml.

Ah okay. I'll keep that in mind for the case that I need to change config options for cargo-xbuild :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants