Ensure copied Cargo.lock is writable#98
Merged
Merged
Conversation
astro
force-pushed
the
writable-cargo-lock
branch
from
November 13, 2020 20:15
a75bb56 to
12fa703
Compare
phil-opp
reviewed
Nov 16, 2020
phil-opp
left a comment
phil-opp
left a comment
Member
There was a problem hiding this comment.
Thanks! I left two inline comments about the error handling, but otherwise this looks good to me.
> If the path pointed to by XARGO_RUST_SRC contains read-only Cargo > lockfiles, then xbuild fails because the copies it makes and attempts to > modify are also read-only.
astro
force-pushed
the
writable-cargo-lock
branch
from
January 21, 2021 22:18
12fa703 to
8f597f3
Compare
Author
|
Thank you for your feedback. PR updated. |
Member
|
Thanks! |
phil-opp
added a commit
that referenced
this pull request
Jan 25, 2021
Member
|
Published as v0.6.5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated from #96: