Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(alloc_ref): Use new nightly Allocator trait #42

Merged
merged 1 commit into from Dec 10, 2020
Merged

fix(alloc_ref): Use new nightly Allocator trait #42

merged 1 commit into from Dec 10, 2020

Conversation

haraldh
Copy link
Contributor

@haraldh haraldh commented Dec 10, 2020

Due to nightly changes, AllocRef was renamed Allocator and the
methods don't take a &mut self anymore. Therefore Heap cannot
implement Allocator anymore. Implement it for LockedHeap instead,
which requires the use_spin feature.

@haraldh
fix(alloc_ref): Use new nightly Allocator trait
48ec45e 
Due to nightly changes, `AllocRef` was renamed `Allocator` and the
methods don't take a `&mut self` anymore. Therefore `Heap` cannot
implement `Allocator` anymore. Implement it for `LockedHeap` instead,
which requires the `use_spin` feature.
@haraldh haraldh mentioned this pull request Dec 10, 2020
Merged
@phil-opp
Copy link
Member

Thanks a lot!

@phil-opp phil-opp merged commit ec2423f into rust-osdev:master Dec 10, 2020
phil-opp added a commit that referenced this pull request Dec 10, 2020
@phil-opp
Update changelog for #42
e29d3af
@phil-opp phil-opp mentioned this pull request Jan 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@haraldh @phil-opp