Add support for multiboot2. #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
marked this pull request as draft
ghost
marked this pull request as ready for review
ghost
changed the title
Author
|
@rust-osdev/multiboot2 Ready for review! May I be added to the organization? I would like to help clear up some issues as I plan to use this crate in some embedded apps. |
Member
|
@Caduser2020 I sent you an invite to the organization! I'm no longer a member of the @rust-osdev/multiboot2 team, though, so I'll leave the review to others. |
IsaacWoods
approved these changes
Aug 10, 2020
Member
|
Travis isn't reporting the status for some reason, but I've checked and this PR passes CI. Code looks fine to me too, thanks for the contribution! @Caduser2020 - I can add you to our multiboot2 team once you've accepted the invitation to the organisation. Ping me here or on Gitter when you've done so :) |
Author
|
@IsaacWoods Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #30
Multiboot 2.0
TODO: