uefi: improve ergonomics of Events #1840
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is nothing unsafe here. `NonNull` properly covers null pointers by returning `None`.
For all three functions, it is the normal / good case to be there. We can also see this in the edk2 implementations of the corresponding functions.
| pub unsafe fn from_ptr(ptr: *mut c_void) -> Option<Self> { | ||
| /// Create an [`Event`] from a raw pointer. Returns [`None`] if the pointer | ||
| /// null. | ||
| pub fn from_ptr(ptr: *mut c_void) -> Option<Self> { |
Member
There was a problem hiding this comment.
I don't think this should be a safe operation. While it's true that the body of the function doesn't do anything unsafe, if you create an Event from an invalid pointer and pass it into some other function that expects a valid Event, it may crash or lead to some other UB.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve ergonomics of Events. Closes #1839
Checklist