Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update x86_64 requirement from 0.13.1 to 0.13.2 #198

Merged
merged 2 commits into from Feb 17, 2021

Conversation

sreehax
Copy link
Contributor

@sreehax sreehax commented Feb 15, 2021

This is needed because nightly removed the const_in_array_repeat_expressions feature.

@GabrielMajeri
Copy link
Collaborator

Thanks for the fix!

It seems some clippy lints are failing, could you also address those in this same PR?

@sreehax
Copy link
Contributor Author

sreehax commented Feb 15, 2021

Hmm it seems that the clippy lints are from code I didn't touch personally, and they're all due to capitalized acronyms in src/proto (RGB, BGR, BIOSBootSpec, etc.) Should I change those to the suggested values? I'm not sure but that may be a breaking change if people are using those directly.

@sreehax
Copy link
Contributor Author

sreehax commented Feb 15, 2021

I can definitely change it I just hope that my change doesn't inadvertently break anything

@GabrielMajeri
Copy link
Collaborator

@sreehax Yes, sometimes Clippy gets updated and the existing code breaks. I will keep in mind to publish a new minor version instead of a patch, to indicate breaking changes.

@sreehax
Copy link
Contributor Author

sreehax commented Feb 16, 2021

Ok cool, I just fixed the clippy lints and updated uefi-test-runner with that in mind to verify everything works. It should be all good now!

@GabrielMajeri GabrielMajeri merged commit 5e796c7 into rust-osdev:master Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants