Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make FrameDeallocator::deallocate_frame unsafe #146

merged 1 commit into from Apr 11, 2020


Copy link

@phil-opp phil-opp commented Apr 11, 2020

This method should be unsafe because the caller must ensure that the passed frame is unused. Prior to #135, this was ensured by the UnusedPhysFrame type, which is now removed.

This is a breaking change.

Reported in 8a257cc#r38430639.

@phil-opp phil-opp merged commit bd6e56b into master Apr 11, 2020
@phil-opp phil-opp deleted the unsafe-frame-dealloc branch April 11, 2020 11:54
phil-opp added a commit that referenced this pull request Apr 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

1 participant