PCID support instructions#169
Merged
Merged
Conversation
vinaychandra
commented
Jul 7, 2020
vinaychandra
commented
Contributor
- Add CR3 support for PCID
- Add invpcid instruction to flush TLB
Contributor
Author
|
@phil-opp can you please carefully review the assembly usage and comment as needed. |
Contributor
Author
|
@phil-opp Ping! |
phil-opp
reviewed
Jul 29, 2020
phil-opp
left a comment
phil-opp
left a comment
Member
There was a problem hiding this comment.
Sorry for the delay! I was a bit busy the past weeks.
I left a few comments about things that could be improved in my opinion, but otherwise this looks good to me. Thanks!
josephlr
reviewed
Sep 23, 2020
Member
|
@vinaychandra Friendly ping :). |
phil-opp
added
the
waiting-on-author
Contributor
Author
|
Thanks for the ping. Updated the PR |
phil-opp
added
waiting-for-review
phil-opp
reviewed
Dec 28, 2020
phil-opp
left a comment
phil-opp
left a comment
Member
There was a problem hiding this comment.
Thanks! I left one comment inline, otherwise this looks good to me.
phil-opp
added
waiting-on-author
phil-opp
added
waiting-for-review
Member
|
Thanks! |
phil-opp
removed
the
waiting-for-review
phil-opp
added a commit
that referenced
this pull request
Dec 29, 2020
Member
|
Published as v0.13.1 |
This was referenced Mar 17, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.