Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide functions for accessing the underlying L4 table for mapper types #184

Merged
merged 1 commit into from Oct 5, 2020

Conversation

phil-opp
Copy link
Member

This is useful for setting up the recursive page table mapping in the UEFI bootloader implementation. I also think that this method makes sense in general, e.g. for determining unused memory ranges for new mappings.

Copy link
Contributor

@josephlr josephlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense. Some qjestions (that don't impact approval).

  • Should we have a common trait for this mapper types?
  • Is there a way to get the physical address of the L4 table for these mappers, so that we can load CR4?

@phil-opp
Copy link
Member Author

phil-opp commented Oct 5, 2020

Thanks for the review!

  • Should we have a common trait for this mapper types?

I thought about that too. Using the existing Mapper/MapperAllSizes traits does not seem fitting to me, but perhaps it makes sense to add a new trait for it (especially if we add more such methods).

  • Is there a way to get the physical address of the L4 table for these mappers, so that we can load CR4?

Yes, there is. We could for example reuse the MapperAllSizes::translate method for that.

@josephlr josephlr merged commit 3d988fc into master Oct 5, 2020
@josephlr josephlr deleted the access-level-4-table branch October 5, 2020 23:12
phil-opp added a commit that referenced this pull request Oct 31, 2020
phil-opp added a commit that referenced this pull request Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants