Provide functions for accessing the underlying L4 table for mapper types#184
Merged
Provide functions for accessing the underlying L4 table for mapper types#184
Conversation
4f42c9b to
ee89ef2
Compare
josephlr
approved these changes
Oct 4, 2020
Contributor
josephlr
left a comment
There was a problem hiding this comment.
This makes sense. Some qjestions (that don't impact approval).
- Should we have a common trait for this mapper types?
- Is there a way to get the physical address of the L4 table for these mappers, so that we can load CR4?
Member
Author
|
Thanks for the review!
I thought about that too. Using the existing
Yes, there is. We could for example reuse the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is useful for setting up the recursive page table mapping in the UEFI bootloader implementation. I also think that this method makes sense in general, e.g. for determining unused memory ranges for new mappings.