Use custom error types instead of () - #199
Merged
Merged
Conversation
14 tasks
phil-opp
force-pushed
the
custom-error-types
branch
from
December 28, 2020 10:03
8752e3c to
f2039dd
Compare
phil-opp
added a commit
that referenced
this pull request
Dec 28, 2020
This fixes the clippy warnings we currently see on CI. Since this changes the signature of public functions, this is a **breaking change**. However, I don't expect that much code is broken by this.
phil-opp
force-pushed
the
custom-error-types
branch
from
December 28, 2020 10:06
41110d2 to
7544957
Compare
phil-opp
enabled auto-merge
December 28, 2020 10:06
Merged
This was referenced Mar 17, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the clippy warnings we currently see on CI.
Since this changes the signature of public functions, this is a breaking change. However, I don't expect that much code is broken by this.