Don't deny warnings on CI #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clippy sometimes introduces new stylistic warnings and we don't want to break our build over this.
Rust/Cargo sometimes add new stylistic warnings too.
|
The warnings are now shown inline in the "Files Changed" tab and also on the build overview page. |
phil-opp
force-pushed
the
update-ci
branch
3 times, most recently
from
73a3f5a
to
3e4c6fe
Compare
rybot666
approved these changes
Nov 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Sometimes Rust/Cargo or clippy introduce new (stylistic) warnings. We don't want to break our CI build over those. This PR changes or CI script to report these warning in the Github UI instead.