feat(paging): Also return flags for MapperAllSizes::translate() - #207
Conversation
|
Thanks a lot for the PR! Looks good to me overall, I would just prefer to introduce a new local variable Given that this a breaking change (albeit a small one), I won't merge this directly, but instead try to combine it with other breaking changes (see #193) to limit the number of version bumps we need to do. I hope that this is ok with you. |
Extend `TranslateResult` returned by `MapperAllSizes::translate()` with the page flags. This way, there is a method to get the flags for the page of a `VirtAddr`.
|
@phil-opp thanks, here we go with a new local variable |
|
Thank you! I'll merge this into a |
|
I just saw that we had an older PR that implements exactly this change: #150. In #150 (comment) I suggested an alternative layout for the |
|
I opened the PR at #211. |
Extend
TranslateResultreturned byMapperAllSizes::translate()withthe page flags. This way, there is a method to get the flags for the
page of a
VirtAddr.Edit(phil-opp): This is a breaking change.