Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement more fmt traits for addr types #237

merged 4 commits into from Mar 27, 2021


Copy link

Some minor improvements for debug traits for the address types:

  • Adds fmt::Binary, fmt::LowerHex, fmt::Octal, fmt::UpperHex impls for VirtAddr
  • Adds fmt::Pointer impls for VirtAddr and PhysAddr
  • Use fmt::Formatter::debug_tuple in the fmt::Debug impls so formatting flags are respected

src/ Show resolved Hide resolved
@dbeckwith dbeckwith changed the title Implement fmt traits for addr types Implement more fmt traits for addr types Mar 27, 2021
Copy link
Contributor Author

The windows build failures seem unrelated to my changes.

Copy link

Looks good to me, thanks! The Windows build is currently broken because of a bug in QEMU, so it has nothing to do with this PR.

@phil-opp phil-opp merged commit 7c2b26d into rust-osdev:master Mar 27, 2021
phil-opp added a commit that referenced this pull request Mar 27, 2021
Copy link

Published as v0.13.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants