Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for x86-interrupt calling convention #242

merged 4 commits into from Apr 11, 2021


Copy link

@phil-opp phil-opp commented Apr 10, 2021

It looks like the x86-interrupt calling convention passes the InterruptStackFrame by value, not by reference: rust-lang/rust#40180 (comment). Apparently, by-ref worked as well before Rust upgraded to LLVM 12, but it no longer works on the latest nightlies. This pull request fixes the IDT to require a by-value stack frame parameter.

Since modifying the interrupt stack frame now requires a volatile write, this PR changes the return type of the InterruptStackFrame::as_mut function to a Volatile<_> reference.

This is a breaking change.

@phil-opp phil-opp enabled auto-merge April 11, 2021 11:17
@phil-opp phil-opp merged commit 27b3917 into master Apr 11, 2021
@phil-opp phil-opp deleted the x86-interrupt-cc branch April 11, 2021 11:21
Copy link
Member Author

Published as v0.14.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

1 participant