Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gdt: Fix off-by-one error in from_raw_slice() #269

Merged
merged 1 commit into from Jul 7, 2021
Merged

Conversation

josephlr
Copy link
Contributor

We use our poor-man's assert instead of trying to do math.

Fixes error pointed out by @toku-sa-n and @phil-opp here: #255 (comment)

Uses technique from: #264 (comment)

Signed-off-by: Joe Richey joerichey@google.com

@josephlr josephlr requested a review from phil-opp June 22, 2021 09:27
@josephlr josephlr mentioned this pull request Jun 22, 2021
@josephlr
Copy link
Contributor Author

josephlr commented Jul 7, 2021

@phil-opp does this look good?

@josephlr josephlr enabled auto-merge (squash) July 7, 2021 13:21
We use our poor-man's assert instead of trying to do math.

Signed-off-by: Joe Richey <joerichey@google.com>
Copy link
Member

@phil-opp phil-opp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@josephlr josephlr merged commit 134cacd into master Jul 7, 2021
@josephlr josephlr deleted the off_by_one branch July 7, 2021 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants