Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove raw-cpuid dependency and use rdrand intrinsics #85

Merged
merged 1 commit into from Jul 19, 2019

Conversation

@64
Copy link
Contributor

commented Jul 18, 2019

This reduces my compile times from scratch from about 215s to 160s.

@phil-opp

This comment has been minimized.

Copy link
Member

commented Jul 19, 2019

I think the test timeouts are caused by the llvm upgrade of Rust. Somehow older versions of the bootloader error with "page already mapped" when trying to run the test binaries (but interestingly not when running the normal kernel binary). I'll push an update that updates the bootloader version, this should fix the CI failure.

@phil-opp

This comment has been minimized.

Copy link
Member

commented Jul 19, 2019

Test update in #86

@phil-opp
Copy link
Member

left a comment

Looks good to me! Thanks!

bors r+

bors bot added a commit that referenced this pull request Jul 19, 2019

Merge #85 #86
85: Remove raw-cpuid dependency and use rdrand intrinsics r=phil-opp a=64

This reduces my compile times from scratch from about 215s to 160s.

86: Update integration tests to use new testing framework r=phil-opp a=phil-opp

Use `cargo xtest` and `bootimage runner` instead of the old `bootimage test` for testing. See https://os.phil-opp.com/testing/ for more information on the approach.

Co-authored-by: Matt Taylor <mstaveleytaylor@gmail.com>
Co-authored-by: Philipp Oppermann <dev@phil-opp.com>
@bors

This comment has been minimized.

Copy link
Contributor

commented Jul 19, 2019

Build succeeded

  • rust-osdev.x86_64

@bors bors bot merged commit d21458f into rust-osdev:master Jul 19, 2019

2 of 7 checks passed

continuous-integration/travis-ci/push The Travis CI build could not complete due to an error
Details
rust-osdev.x86_64 Build #20190718.1 failed
Details
rust-osdev.x86_64 (Job linux) Job linux failed
Details
rust-osdev.x86_64 (Job mac) Job mac failed
Details
rust-osdev.x86_64 (Job windows) Job windows failed
Details
bors Build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

phil-opp added a commit that referenced this pull request Jul 19, 2019

@phil-opp

This comment has been minimized.

Copy link
Member

commented Jul 19, 2019

Published as version 0.7.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.