Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.2.8 #294

Merged
merged 1 commit into from
Oct 20, 2022
Merged

Release v0.2.8 #294

merged 1 commit into from
Oct 20, 2022

Conversation

josephlr
Copy link
Member

Also updates the changelog

We should probably release this before the major changes in #291

Signed-off-by: Joe Richey joerichey@google.com

CHANGELOG.md Outdated
## [0.2.8] - 2022-10-20
### Added

- [Web Crypto API] can now be used on Node.js if avalible [#284]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new lines after subsection are redundant and not consistent with entries for other versions.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This, and the other documentation, leave it ambiguous about which API will be used when both are detected. The big table in lib.rs's module doc is actively misleading, if I am understanding correctly that the webcrypto API is preferred if detected.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fair. I've fixed the spacing and spelling issues. I've also moved the WebCrypto stuff to the Changed section and actually elaborated on what we changed.

Let me know if it looks good to y'all.

I've also opened #295 to update the table in the Rust Docs.

Also updates the changelog

Signed-off-by: Joe Richey <joerichey@google.com>
@josephlr
Copy link
Member Author

Merging this, now that #295 is merged.

@josephlr josephlr merged commit 5c1bb00 into rust-random:master Oct 20, 2022
@josephlr josephlr deleted the release branch October 20, 2022 20:53
@josephlr
Copy link
Member Author

Tag: https://github.com/rust-random/getrandom/releases/tag/v0.2.8
Published: https://crates.io/crates/getrandom/0.2.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants