Fix Geometric::new for small p>0 #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // NOTE: Some distributions have tests checking only that samples can be | ||
| // generated. This is redundant with vector and correctness tests. | ||
|
|
||
| /// An RNG which panics on first use |
Member
There was a problem hiding this comment.
what is the usage for this?
Member
Author
There was a problem hiding this comment.
The test I added needs an RNG to call sample but doesn't actually use it.
This allows asserting that the call to sample doesn't use the RNG.
Member
Author
There was a problem hiding this comment.
(The name is dubious, but I don't think NeverRng or DummyRng is any better.)
src/geometric.rs
Outdated
|
|
||
| impl Geometric { | ||
| /// Construct a new `Geometric` with the given shape parameter `p` | ||
| /// (probability of success on each trial). |
Member
There was a problem hiding this comment.
Maybe add: If p is zero or 1.0 - p rounds to 1.0 we return u64::MAX
Either make it like this or have it as implementation detail potentially subject to change.
Member
Author
|
I'll ignore the test failure here (not relevant to this PR). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG.mdentrySummary
The case where
p>0but1 - prounds to 1 was not previously handled. Now we handle it the same as forp=0.Fixes #34.