Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using generic types to specify column families when opening database... #255

Merged
merged 3 commits into from
Feb 5, 2019

Conversation

iSynaptic
Copy link
Member

@iSynaptic iSynaptic commented Feb 4, 2019

This change requires no changes to existing tests. Fixes #175 and fixes #177.

@iSynaptic
Copy link
Member Author

@DarkEld3r I hope this change represents a happy medium between the way open_cf has worked in the past and your suggestion in #177. Rather than creating a new constructor, the existing ones should be easier to use. For example:

let options = Options::default();
let cfs = DB::list_cf(&options, &n).unwrap();
let db = DB::open_cf(&options, &n, &cfs).unwrap();

src/db.rs Outdated Show resolved Hide resolved
src/db.rs Show resolved Hide resolved
src/db.rs Show resolved Hide resolved
@iSynaptic iSynaptic merged commit 2ade946 into rust-rocksdb:master Feb 5, 2019
@iSynaptic iSynaptic deleted the gh-175 branch February 5, 2019 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Database opening ergonomics DB::open_cf signature
3 participants