Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable cross compilation #323

Merged
merged 2 commits into from Aug 28, 2019

Conversation

@bddap
Copy link
Contributor

bddap commented Aug 26, 2019

Fixes cross-compilation by addressing #322.

@bddap bddap changed the title enable cross compilation by fix #322 enable cross compilation Aug 26, 2019
@vitvakatu

This comment has been minimized.

Copy link
Contributor

vitvakatu commented Aug 27, 2019

Thank you for a PR. Could you please fix trailing spaces on the added blank line to make rustfmt happy?

@@ -45,6 +45,8 @@ fn bindgen_rocksdb() {
}

fn build_rocksdb() {
let target = env::var("TARGET").unwrap();

This comment has been minimized.

Copy link
@aleksuss

aleksuss Aug 27, 2019

Member

If we don't set env variable "TARGET" we would get a panic. Is it really ok here ? What if get a target from cfg!(target_arch) by default, but if "TARGET" variable was set then get the value from it?

This comment has been minimized.

Copy link
@bddap

bddap Aug 27, 2019

Author Contributor

Cargo build passes the "TARGET" environment variable unconditionally.

fmt
@bddap

This comment has been minimized.

Copy link
Contributor Author

bddap commented Aug 27, 2019

@vitvakatu the formatting issue has been fixed.

Copy link
Contributor

vitvakatu left a comment

Thanks!

@aleksuss aleksuss merged commit 73d5e00 into rust-rocksdb:master Aug 28, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.