Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for data block hash index #358

Merged

Conversation

dvdplm
Copy link
Contributor

@dvdplm dvdplm commented Nov 28, 2019

A good description of the feature enabled by this is found here.

Note: the librocksdb used by rust-rocksdb does not expose the necessary functions in the C api; pending PR upstream: facebook/rocksdb#6101. EDIT: merged.

Currently blocked on #398

Copy link
Contributor

@ordian ordian left a comment

would be nice to add a test

src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
dvdplm and others added 8 commits Mar 24, 2020
…ta-block-index-type

* upstream/master:
  Make DBPath use tempfile. (rust-rocksdb#394)
  Add a doc for optimize_level_style_compaction method (rust-rocksdb#392)
  Fix lifetime parameter for iterators (rust-rocksdb#391)
  Bump librocksdb-sys up to 6.6.4 (rust-rocksdb#389)
  Change APIs that never return error to not return Result (rust-rocksdb#383)
  Do not take into account a windows host build for overall CI status (rust-rocksdb#388)
  Bump uuid and bindgen dependencies (rust-rocksdb#387)
  Fix doc for WriteBatch::delete (rust-rocksdb#376)
  Move to Rust 2018 (rust-rocksdb#375)
  Fix potential segfault when calling next on DBIterator that is at the end of the range (rust-rocksdb#374)
  Minor cleanup in db.rs (rust-rocksdb#373)
  Add flush_cf method to DB (rust-rocksdb#372)
  Simplify conversion on iterator item (rust-rocksdb#364)
  Add set_max_total_wal_size to Options (rust-rocksdb#366)
  Fix minor doc typo (rust-rocksdb#367)
  Options: add set_ratelimiter (rust-rocksdb#369)
  Improve ffi_try macro to make trailing comma optional (rust-rocksdb#371)
  Upgrade rocksdb to v6.4.6 (rust-rocksdb#360)
* upstream/master:
  Make DBPath use tempfile. (rust-rocksdb#394)
  Add a doc for optimize_level_style_compaction method (rust-rocksdb#392)
  Fix lifetime parameter for iterators (rust-rocksdb#391)
  Bump librocksdb-sys up to 6.6.4 (rust-rocksdb#389)
  Change APIs that never return error to not return Result (rust-rocksdb#383)
  Do not take into account a windows host build for overall CI status (rust-rocksdb#388)
  Bump uuid and bindgen dependencies (rust-rocksdb#387)
  Fix doc for WriteBatch::delete (rust-rocksdb#376)
  Move to Rust 2018 (rust-rocksdb#375)
  Fix potential segfault when calling next on DBIterator that is at the end of the range (rust-rocksdb#374)
  Minor cleanup in db.rs (rust-rocksdb#373)
  Add flush_cf method to DB (rust-rocksdb#372)
  Simplify conversion on iterator item (rust-rocksdb#364)
  Add set_max_total_wal_size to Options (rust-rocksdb#366)
  Fix minor doc typo (rust-rocksdb#367)
  Options: add set_ratelimiter (rust-rocksdb#369)
  Improve ffi_try macro to make trailing comma optional (rust-rocksdb#371)
  Upgrade rocksdb to v6.4.6 (rust-rocksdb#360)
* rocksdb-6.7.0:
  Updated rocksdb submodule
  Bump version to 0.14.0-alpha.1
  Upgrade to rocksdb 6.7.0 (unreleased)
Co-Authored-By: Andronik Ordian <write@reusable.software>
Co-Authored-By: Andronik Ordian <write@reusable.software>
Co-Authored-By: Andronik Ordian <write@reusable.software>
@dvdplm dvdplm marked this pull request as ready for review Mar 29, 2020
dvdplm added 2 commits Apr 7, 2020
* 'master' of https://github.com/rust-rocksdb/rust-rocksdb:
  Check if we're on a big endian system and act upon it (rust-rocksdb#396)
  Refactor db.rs and lib.rs into smaller pieces (rust-rocksdb#395)
* master:
  Check if we're on a big endian system and act upon it (rust-rocksdb#396)
  Refactor db.rs and lib.rs into smaller pieces (rust-rocksdb#395)
@ordian
Copy link
Contributor

ordian commented Apr 8, 2020

please merge with master

…ta-block-index-type

* upstream/master:
  Atomic flush option (rust-rocksdb#380)
  Bump rocksdb version up to 6.7.3 (rust-rocksdb#398)
  Bump internal snappy version up to 1.1.8 (rust-rocksdb#397)
@dvdplm
Copy link
Contributor Author

dvdplm commented Apr 8, 2020

@aleksuss PTAL

dvdplm added 4 commits Apr 8, 2020
* upstream/master:
  Atomic flush option (rust-rocksdb#380)
  Bump rocksdb version up to 6.7.3 (rust-rocksdb#398)
  Bump internal snappy version up to 1.1.8 (rust-rocksdb#397)
Copy link
Member

@aleksuss aleksuss left a comment

LGTM

@aleksuss aleksuss merged commit 3282b2f into rust-rocksdb:master Apr 8, 2020
1 check passed
@dvdplm dvdplm deleted the dp/feature/add-data-block-index-type branch Apr 8, 2020
rleungx pushed a commit to rleungx/rust-rocksdb that referenced this issue Jun 17, 2020
Improve documentation.

Signed-off-by: loxp <loxppqqxol@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants