Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some extra config options #399

Merged
merged 7 commits into from Apr 8, 2020
Merged

Conversation

casualjim
Copy link
Contributor

@casualjim casualjim commented Mar 29, 2020

adds options that I have in use in a go version of the current library I'm working on:

  • set_pipelined_write,
  • memtable_huge_page_size
  • optimize_universal_style_compaction

…ze_universal_style_compaction

Signed-off-by: Ivan Porto Carrero <ivan@flanders.co.nz>
Signed-off-by: Ivan Porto Carrero <ivan@flanders.co.nz>
src/db_options.rs Show resolved Hide resolved
src/db_options.rs Show resolved Hide resolved
Signed-off-by: Ivan Porto Carrero <ivan@flanders.co.nz>
@casualjim
Copy link
Contributor Author

casualjim commented Mar 30, 2020

I took care of this now

@@ -186,12 +186,41 @@ impl Drop for ReadOptions {
}

impl BlockBasedOptions {
/// Approximate size of user data packed per block. Note that the
Copy link
Member

@aleksuss aleksuss Mar 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for nagging but decrease amount of spaces between sentences please.

Signed-off-by: Ivan Porto Carrero <ivan@flanders.co.nz>
src/db_options.rs Outdated Show resolved Hide resolved
Co-Authored-By: Oleksandr Anyshchenko <aanischenko@gmail.com>
src/db_options.rs Outdated Show resolved Hide resolved
casualjim and others added 2 commits Mar 30, 2020
Co-Authored-By: Oleksandr Anyshchenko <aanischenko@gmail.com>
@aleksuss aleksuss changed the title adds some extra config options Add some extra config options Apr 8, 2020
@aleksuss aleksuss merged commit a0e5d99 into rust-rocksdb:master Apr 8, 2020
1 check passed
rleungx pushed a commit to rleungx/rust-rocksdb that referenced this issue Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants