Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for range delete APIs #403

Merged
merged 1 commit into from Apr 15, 2020
Merged

Conversation

wqfish
Copy link
Contributor

@wqfish wqfish commented Apr 12, 2020

This change exposes the range delete C APIs added in facebook/rocksdb#6259.

This change exposes the range delete C APIs added in
facebook/rocksdb#6259.
@ordian
Copy link
Contributor

ordian commented Apr 12, 2020

@aleksuss
Copy link
Member

aleksuss commented Apr 12, 2020

Obviously, that it could be done directly via DB rather than via WriteBatch ?

@aleksuss aleksuss requested review from vitvakatu and aleksuss Apr 12, 2020
@ordian
Copy link
Contributor

ordian commented Apr 12, 2020

In terms of functionality, this PR provides a way pass WriteOptions to delete range function. Would be nice to document how a user is supposed use that, e.g. which options could be useful when deleting a range.

@wqfish
Copy link
Contributor Author

wqfish commented Apr 12, 2020

How is it different from https://docs.rs/rocksdb/0.13.0/rocksdb/struct.WriteBatch.html#method.delete_range_cf?

It's similar to other methods like put and delete:

  1. They can be done directly on the DB if that's all the user needs
  2. If the user wants to combine the operation with a few other ones and make an atomic write, they do it via WriteBatch.

In terms of functionality, this PR provides a way pass WriteOptions to delete range function. Would be nice to document how a user is supposed use that, e.g. which options could be useful when deleting a range.

The write options aren't specific to the delete_range operation, it's the same for all the write operations. So the documentation probably should go to WriteOptions.

@aleksuss aleksuss merged commit 49c679f into rust-rocksdb:master Apr 15, 2020
1 check passed
@wqfish wqfish deleted the delete_range branch Apr 15, 2020
rleungx pushed a commit to rleungx/rust-rocksdb that referenced this pull request Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants