Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

librocksdb-sys: Add support for building with io_uring on Linux. #621

Merged
merged 1 commit into from Aug 5, 2022

Conversation

parazyd
Copy link
Contributor

@parazyd parazyd commented Mar 17, 2022

No description provided.

librocksdb-sys/build.rs Outdated Show resolved Hide resolved
@aleksuss
Copy link
Member

aleksuss commented May 2, 2022

It would be good to add a new job in a CI for checking this feature.

@parazyd
Copy link
Contributor Author

parazyd commented May 2, 2022

@aleksuss I thought it's better not to silently fall through if the feature is explicitly enabled but the library is unavailable. Would you like me to chane this?

@aleksuss aleksuss requested a review from stanislav-tkach May 2, 2022
@aleksuss
Copy link
Member

aleksuss commented May 2, 2022

Then you probably should add a message to inform a user:

pkg_config::probe_library("liburing").except("The io_uring feature was provided but the library was not found");

or something...

@parazyd
Copy link
Contributor Author

parazyd commented May 2, 2022

Updated. Thanks.

Copy link
Member

@aleksuss aleksuss left a comment

Fix the typo in method expect please.

librocksdb-sys/build.rs Outdated Show resolved Hide resolved
librocksdb-sys/build.rs Outdated Show resolved Hide resolved
@aleksuss aleksuss merged commit 03f10c0 into rust-rocksdb:master Aug 5, 2022
6 checks passed
vldm pushed a commit to velas/rust-rocksdb that referenced this issue Sep 8, 2022
msmouse pushed a commit to aptos-labs/rust-rocksdb that referenced this issue Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants