Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 'bz_internal_error': symbol multiply defined! #628

Merged
merged 1 commit into from May 2, 2022
Merged

fix: 'bz_internal_error': symbol multiply defined! #628

merged 1 commit into from May 2, 2022

Conversation

nanpuyue
Copy link
Contributor

@nanpuyue nanpuyue commented Apr 28, 2022

Fix: #609

The bz_internal_error was introduced when bzip2 support was added, the bzip2-sys crate was not used at that time.
This function should be removed after using bzip2-sys crate, otherwise it will conflict with the definition in bzip2-sys when compiled with lto enabled.

@nanpuyue
Copy link
Contributor Author

nanpuyue commented Apr 29, 2022

A test failed, but it's ok before rebase.
I have no idea, have a retry? @stanislav-tkach

@stanislav-tkach
Copy link
Contributor

stanislav-tkach commented Apr 30, 2022

The test has passed after restart...

@aleksuss aleksuss merged commit 35674e7 into rust-rocksdb:master May 2, 2022
6 checks passed
@dnrusakov
Copy link

dnrusakov commented May 29, 2022

Is it possible to release a new version of the rocksdb crate in order to accommodate this change? The current version available on crates.io is 0.18.0 and it doesn't have all recent changes including this one. cc @aleksuss @stanislav-tkach

@joleeee
Copy link

joleeee commented Jul 2, 2022

It's now 4 months since the original issue, and 2 months since it was fixed, but no new crate release. Like @dnrusakov said, it would be great if a new release could be made

@joleeee
Copy link

joleeee commented Jul 2, 2022

A temporary workaround apart from using the git version is to disable default-features

rocksdb = { version = "0.18.0", default-features = false, features = [ ... ] }

jasl pushed a commit to jasl/rust-rocksdb that referenced this pull request Aug 12, 2022
vldm pushed a commit to velas/rust-rocksdb that referenced this pull request Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

librocksdb_sys::bz_internal_error conflicts with bzip2-sys::bz_internal_error
5 participants