Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to rocksdb v7.3.1 #645

Merged
merged 1 commit into from Jun 27, 2022
Merged

Conversation

yhchiang-sol
Copy link
Contributor

@yhchiang-sol yhchiang-sol commented Jun 21, 2022

This PR upgrades to rocksdb v7.3.1.
v7.3.1 release note (https://github.com/facebook/rocksdb/releases/tag/v7.3.1).

@yhchiang-sol
Copy link
Contributor Author

yhchiang-sol commented Jun 21, 2022

I'm not able to get around with the following linking error:

  = note: Undefined symbols for architecture arm64:
            "rocksdb::ObjectRegistry::builtins_", referenced from:
                rocksdb::ObjectRegistry::ObjectRegistry(std::__1::shared_ptr<rocksdb::ObjectLibrary> const&) in liblibrocksdb_sys-d6e9cb3766a4628b.rlib(object_registry.o)
          ld: symbol(s) not found for architecture arm64
          clang: error: linker command failed with exit code 1 (use -v to see invocation)

It seems related to a recent change from facebook/rocksdb#7949 that introduces a new static builtins_ defined in build_version.cc, but somehow it causes the link error.

Does anyone happen to know how to fix it?

@yhchiang-sol
Copy link
Contributor Author

yhchiang-sol commented Jun 21, 2022

Manually replacing the build_version.cc under librocksdb-sys by building rocksdb and copying the output build_version.cc solved the above error.

@yhchiang-sol yhchiang-sol force-pushed the rocks-7.3.1 branch 3 times, most recently from 6a7b400 to 7a409a2 Compare Jun 23, 2022
tests/test_db.rs Outdated Show resolved Hide resolved
@@ -529,6 +529,10 @@ impl Iterator for DBWALIterator {
type Item = (u64, WriteBatch);

fn next(&mut self) -> Option<(u64, WriteBatch)> {
if !self.valid() {
Copy link
Contributor Author

@yhchiang-sol yhchiang-sol Jun 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self.valid() check is added before invoking the ffi.

@yhchiang-sol
Copy link
Contributor Author

yhchiang-sol commented Jun 23, 2022

@stanislav-tkach Updated the PR to include a validity check inside the next call. Looks like the test workflow needs maintainers' approval once again after the PR is updated. Can you help approve the flow? Thank you!

@yhchiang-sol
Copy link
Contributor Author

yhchiang-sol commented Jun 24, 2022

Hello @aleksuss, hope everything is going well on your side. This PR upgrades rocksdb to 7.3.1 and need your review. Can you help review the PR when you're more available? Thank you!

@yhchiang-sol
Copy link
Contributor Author

yhchiang-sol commented Jun 25, 2022

Hello @aleksuss, we Solana needs this PR and #633 in order to use the optimized version of multi-get to speed up our read requests. Both PRs have been waiting for your review for around a week. Do you mind reviewing this PR that upgrades rocksdb to v7.3.1 and #633 that adds the optimized version of multi-get api? Thank you so much!

@yhchiang-sol
Copy link
Contributor Author

yhchiang-sol commented Jun 26, 2022

Hello @stanislav-tkach. While the PR has one approval, it looks like I am not able to merge it.

If the PR looks good to you, do you mind helping me merge the PR? Thank you!

@aleksuss aleksuss merged commit da4b714 into rust-rocksdb:master Jun 27, 2022
6 checks passed
@yhchiang-sol
Copy link
Contributor Author

yhchiang-sol commented Jun 27, 2022

Thank you so much, @aleksuss!

vldm pushed a commit to velas/rust-rocksdb that referenced this issue Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants