Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid pulling in dependencies via static feature flag #649

Merged
merged 1 commit into from Aug 5, 2022

Conversation

niklasf
Copy link
Contributor

@niklasf niklasf commented Jun 28, 2022

The static feature flag needs to set feature flags in dependencies. Unfortunately this unconditionally pulls in the dependency, even if it would not otherwise be enabled/needed.

Rust 1.60 introduces weak dependency features for this exact use case.

Do we have a policy about the minimum supported Rust version?

@aleksuss aleksuss merged commit 934855f into rust-rocksdb:master Aug 5, 2022
6 checks passed
vldm pushed a commit to velas/rust-rocksdb that referenced this pull request Sep 8, 2022
msmouse pushed a commit to aptos-labs/rust-rocksdb that referenced this pull request Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants