Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upCommon traits PartialEq, Eq and Hash #74
Conversation
This comment has been minimized.
This comment has been minimized.
|
Currently the build fails prior to rustc 1.12.0 because of the Should we work around it or update the min version? Debian 9 stable currently serves rust 1.14.0 with the default installation. |
This comment has been minimized.
This comment has been minimized.
|
|
dns2utf8
added some commits
Jul 15, 2017
dns2utf8
force-pushed the
dns2utf8:common_traits
branch
from
0166379
to
aeec3d7
Jul 28, 2017
dns2utf8
added some commits
Jul 15, 2017
dns2utf8
force-pushed the
dns2utf8:common_traits
branch
from
db6eaa3
to
b9ff22f
Jul 28, 2017
This comment has been minimized.
This comment has been minimized.
|
My intention was to implement everything I thought reasonable. I implemented it from the list of this document referenced here: We could also split this PR and only merge the |
This comment has been minimized.
This comment has been minimized.
|
cherry-picked your |
frewsxcv
closed this
Aug 11, 2017
This comment has been minimized.
This comment has been minimized.
|
Cool, thank you! |
dns2utf8 commentedJul 15, 2017
I implemented PartialEq, Eq and Hash. Others like Copy or PartialOrd did not seem right.