Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upDocument `.clone()` #79
Conversation
frewsxcv
reviewed
Aug 8, 2017
lib.rs
Outdated
| /// We could for example [`join`](#method.join) a pool from multiple | ||
| /// threads or submit jobs from multiple threads concurrently. | ||
| /// | ||
| /// ``` |
This comment has been minimized.
This comment has been minimized.
frewsxcv
Aug 8, 2017
Collaborator
Sorry for the delay, I'm thinking if there's a simpler example we can put here. I know you're spawning threads so you can show that the ThreadPool can be cloned, but do we need much of the other code here?
This comment has been minimized.
This comment has been minimized.
dns2utf8
Aug 8, 2017
Author
Member
No worries
I could shorten the code by half by using a loop to spawn the threads and then use another loop/fold to join them. Or would you go into a completely different direction?
dns2utf8
added some commits
Aug 5, 2017
dns2utf8
force-pushed the
dns2utf8:doc_clone
branch
from
ce1ea68
to
f7d7975
Aug 9, 2017
This comment has been minimized.
This comment has been minimized.
|
I shortened the example. Reduced the example to submitting jobs from multiple threads. |
This comment has been minimized.
This comment has been minimized.
|
thanks! bors r+ |
bors bot
added a commit
that referenced
this pull request
Aug 10, 2017
This comment has been minimized.
This comment has been minimized.
bors
bot
merged commit d8d3186
into
rust-threadpool:master
Aug 10, 2017
dns2utf8
deleted the
dns2utf8:doc_clone
branch
Aug 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
dns2utf8 commentedAug 5, 2017
The example became rather long but it is the shortest one I could come up with with one pool.
I am open to suggestions.