Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Merges context creation code. #1029
Signed-off-by: Hal Gentz email@example.com
Currently only 4 platforms need testing and one platform needs to get working.
Compiles with the following backends:
Has been tested with the following backends:
francesca64 left a comment
Alright, spending 3 hours reviewing this should be enough for one day...
So far I've only tested on X11 and Android. X11 is broken, but Android appears fine. However, I didn't test any headless stuff.
I can't test things definitively until you've created a suitable example program.
swap_buffers, get_pixel_format and resize, under my understanding, should be panicking for headless contexts. It's nonsensical to, for example, call eglSwapBuffers when there is no visible native window to swap with, even if valid.
(In egl's case, if surface isn't a native window, the function silently does nothing.)
@zegentzy I get what you're saying about the panics, but at bare minimum these panics would have to print explanations and have accompanying documentation notes. Though, what this tells me is that this API design is fairly problematic. I don't think it's reasonable for the API to misrepresent the context's capabilities.
@kvark I won't deny that I'm pushing myself harder than I should, but no one will want to contribute to glutin if PRs don't get reviewed. Just make sure I don't try to become the maintainer of any more of tomaka's repos!